Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to speed up codeql #617

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Attempt to speed up codeql #617

merged 1 commit into from
Sep 21, 2023

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Sep 21, 2023

Does not install and scan every Python dependency for the project per:
https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/customizing-your-advanced-setup-for-code-scanning#analyzing-python-dependencies

Looks like setup-python-dependencies feature is being deprecated anyways.

@dakinggg dakinggg marked this pull request as ready for review September 21, 2023 00:59
Copy link
Contributor

@bandish-shah bandish-shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for figuring this out!

@bandish-shah
Copy link
Contributor

@dakinggg can you make the CodeQL check required after merging this PR?

@dakinggg dakinggg merged commit 512d4ea into mosaicml:main Sep 21, 2023
9 checks passed
@irenedea
Copy link
Contributor

Awesome, thank you!

@dakinggg dakinggg deleted the codql branch October 11, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants